|
|
 | | From: | Gavin Lambert | | Subject: | AllowNoIcons and previous installs | | Date: | Mon, 20 Dec 2004 10:44:53 +1300 |
|
|
 | I was testing out an install recently that had AllowNoIcons=yes. I
noticed that for some odd reason if the user checked "don't create a
start menu folder" then Inno would still write the default start menu
folder name to the Uninstall registry. This meant that the next time
that the installer was run, it defaulted back to creating a start menu
folder (thereby "forgetting" the user's previous selection).
It was actually quite irritating, running the installer multiple times
and having to go and recheck that option each time -- Inno remembered
all the other settings just fine... but not that one.
Martijn pointed me to this thread:
http://news.jrsoftware.org/news/innosetup/msg01641.html
.... and I think I agree with him. The default behaviour should be to
preserve the user's selection. If necessary, maybe create an option
that keeps the current behaviour, but I don't think it should be the
default. It's just not logical.
Regarding the point that Jordan raised (about later versions adding more
icons): if an installer doesn't contain any start menu icons at all,
then the registry key shouldn't be written at all. When a later version
adds icons, then they *should* be installed by default. On the other
hand, when an installer does contain icons, and the user specifically
chose to not create them, then their choice should be respected, even if
a later version adds even more icons. (Maybe give the setup author the
chance to override this -- but side with the user by default.)
You can't just do it based on whether the menu page is shown or not, of
course, since sometimes (upgrades spring to mind) it should be skipped.
But it's still easily detectable whether the user specifically chose
to not install items, or whether they were never given the option (if
there aren't any {group} icons, don't write the value to the registry at
all. If there are icons but the user specifically chose to not install
them, then write an empty string to the registry).
|
|
|
